[Bug] "My Reminder Calendar" Adds Events 1 Day before Deal Start + Other Inconsistent Reminder Behaviour

itsfree on 29/10/2021 - 22:31
Last edited 30/10/2021 - 08:47

I have subscribed to My Reminder Calendar in Google Calendar. I have noticed that added reminders are shown 1 day before the actual offer start date, even though I always select "on the start date". For example, this deal has an all-day start date in my calendar on 30/10, even though the start date is 31/10.

There's inconsistent behaviour with the Add to Google Calendar and Export iCalendar functionalities as well, better demonstrated with this deal:

However, Export iCalendar does get the all-day deals correct (e.g. above Halloween one) – see here.

Site Discussion

Comments

  • sjj89 on 30/10/2021 - 07:26

    Somewhere your time zones are set differently on one of your services, accounts, or devices

    • itsfree on 30/10/2021 - 08:43

      Nope.

      This has happened for as long as I can remember, across every device I've had.

      Edit: Google Calendar site settings too, for good measure.

  • Moderatormoocher on 01/11/2021 - 14:47

    itsfree, I can reproduce the issue that you are describing, even though some of the links you've shared have since expired. Will investigate and fix up.

    • Moderatormoocher on 02/11/2021 - 16:33

      Just to explain a bit about what's going on, the 'Add to Google Calendar' and 'Export iCalendar' options on the node reminder menu actually have no relationship with the on-site reminder date that has been set. The start/end for the calendar event are determined like this (taken from announcement)

      The calendar events will have a duration of 1 day. The 'start' time is determined as follows:

      The start date is used if it exists and is in the future
      The expiry date is used if it exists and is in the future
      Otherwise, tomorrow's date is used and users can edit the event as required.

      This is so that users can set calendar events without having to set any on-site reminder. We were also trying to avoid generating calendar events that spanned for days if the deal runs for multiple days.

      The user reminder calendar export behaves differently - it does hard-code the calendar events to start one day before the actual reminder, and finish either on the deal expiry or 7 days after the event start if there is no expiry. These were historical design decisions, but is something we need to revisit as there are certainly some inconsistencies here and it is confusing.

    • Moderatormoocher on 18/11/2021 - 12:34

      Just an update to say that we've changed a few things and the behaviour should be as follows:

      1. Calendar events exported from node reminder menu have event start/end determined as follows:
        • If user has set reminder, the event has start date of the reminder and end date a day later
        • If user has not set a reminder, the event will use the start date, then end date of the deal (in that order of priority) to add a 1 day reminder.
      2. User's reminder calendar exported from user's reminder page will always have event start matching reminder date and ending a day later.
Login or Join to leave a comment
Login Join